Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the build process #54

Merged
merged 7 commits into from
Nov 4, 2023
Merged

Clean up the build process #54

merged 7 commits into from
Nov 4, 2023

Conversation

matsui528
Copy link
Owner

@matsui528 matsui528 commented Nov 2, 2023

Simplify the build process by following the official guideline.

  • Revise Makefile to install the library by pip install . (now the only proper way)
  • Revise gh actions to run pip install . explicitly.
  • Delete the manual installation of pybind11 in setup.py. Such an approach is deprecated.
  • Delete the legacy tag in pyproject.toml. It seems we don't need it? Also, set the minimum version of pybind11 and setuptools.

Special thanks to @denkiwakame !

@matsui528 matsui528 changed the title Clen up the build process Clean up the build process Nov 2, 2023
@matsui528 matsui528 merged commit 2255091 into main Nov 4, 2023
12 checks passed
@matsui528 matsui528 deleted the build branch November 4, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant